Format Content-Security-Policy header directives
#362
Conversation
LeoColomb
changed the title
Content-Security-Policy header directives
There was a problem hiding this comment.
Thanks for your PR @dcog989.
As you can read in the checks of the PR, the current config is not valid.
Have you tested it on your side?
I believe the following rules apply for multiline expression:
- The last character on all lines except the final one must be a backslash;
- The final line must not terminate with a backslash;
- The Apache comment character (#) cannot be used to comment out a line.
- You cannot break the flags
Fix incorrect location of comment line.
|
Hi Léo. I saw the errors but the meaning wasn't clear to me. I'm new to github and not familiar with all the tools available - and can't find a way to perform the test done when pull request submitted. However, I think the reason for failure was the location of comment line: should be: I'll attempt to update.... |
There was a problem hiding this comment.
Same review I'm afraid, the current config is not valid.
Have you tested it on your side?
I believe the following rules apply for multiline expression:
- The last character on all lines except the final one must be a backslash;
- The final line must not terminate with a backslash;
- The Apache comment character (#) cannot be used to comment out a line.
- You cannot break the flags
Test output can be seen in here: https://github.com/h5bp/server-configs-apache/actions/runs/8256582544/job/22646947712?pr=362#step:4:778
Add backslashes as per h5bp#362 (review)
|
Hey. Now I'm confused - my re-run shows failure status, but here shows 'All checks have passed'?!! As you can see, I added backslashes as per spec. Not sure if I have complied with "You cannot break the flags". |
No description provided.